Fix static annotation of pi.generate_multi_columns_probe#385
Merged
samuelgarcia merged 1 commit intoSpikeInterface:mainfrom Dec 8, 2025
Merged
Fix static annotation of pi.generate_multi_columns_probe#385samuelgarcia merged 1 commit intoSpikeInterface:mainfrom
pi.generate_multi_columns_probe#385samuelgarcia merged 1 commit intoSpikeInterface:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR corrects the type annotation for the num_contact_per_column parameter in generate_multi_columns_probe to accurately reflect that it accepts both int and list[int] types. The function has always supported list input (with automatic conversion from int to list), and this change aligns the type hint with the actual implementation.
Key Changes:
- Updated type annotation from
inttoint | list[int]for thenum_contact_per_columnparameter
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
samuelgarcia
approved these changes
Dec 8, 2025
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pi.generate_multi_columns_probecan receivelist[int]asnum_contact_per_column. And by default, anintvalue will be automatically converted tolist[int].So changing the static annotation of
num_contact_per_column.